build(pip): require java-api 17.26.5+#30
Merged
cesarcoatl merged 2 commits into8.3from Apr 30, 2026
Merged
Conversation
this version introduced java.lang.Record 8.3.5.post1 and beyond will require this
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Python packaging metadata to require at least version 17.26.5 of the java-api dependency, aligning with the need for java.lang.Record support for versions 8.3.5.post1 and later. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- You updated the
java-apiconstraint insetup.cfgbut not inrequirements.in; consider aligning the version requirement there as well to keep dependency definitions consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- You updated the `java-api` constraint in `setup.cfg` but not in `requirements.in`; consider aligning the version requirement there as well to keep dependency definitions consistent.
## Individual Comments
### Comment 1
<location path="setup.cfg" line_range="41" />
<code_context>
enum34
-java-api
+java-api>=17.26.5
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Consider constraining the upper bound of `java-api` or documenting compatibility assumptions.
Using `java-api>=17.26.5` without an upper bound means any future breaking major version will be pulled in, which is risky for a Python 2.7–locked project that may not be updated often. Please either add a conservative upper cap (e.g., `<18`) based on what’s validated, or document a confirmed semver guarantee that future major versions will remain compatible.
```suggestion
# Pin java-api to a compatible major version range for this Python 2.7.18 project.
# Future major versions may introduce breaking changes; adjust the upper bound after validation.
java-api>=17.26.5,<18
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| install_requires = | ||
| enum34 | ||
| java-api | ||
| java-api>=17.26.5 |
Contributor
There was a problem hiding this comment.
suggestion (bug_risk): Consider constraining the upper bound of java-api or documenting compatibility assumptions.
Using java-api>=17.26.5 without an upper bound means any future breaking major version will be pulled in, which is risky for a Python 2.7–locked project that may not be updated often. Please either add a conservative upper cap (e.g., <18) based on what’s validated, or document a confirmed semver guarantee that future major versions will remain compatible.
Suggested change
| java-api>=17.26.5 | |
| # Pin java-api to a compatible major version range for this Python 2.7.18 project. | |
| # Future major versions may introduce breaking changes; adjust the upper bound after validation. | |
| java-api>=17.26.5,<18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this version introduced java.lang.Record
8.3.5.post1 and beyond will require this
Summary by Sourcery
Build: